Deploy new version of Celostats and minnor change from celo-blockchain #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcortejoso
requested review from
nambrot,
timmoreton and
tkporter
as code owners
jcortejoso
force-pushed
the
jcortejoso/deploy_ethstats
branch
from
69188a6
to
7878dba
Compare
tkporter
reviewed
Nov 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
=======================================
Coverage 74.2% 74.2%
=======================================
Files 278 278
Lines 7653 7653
Branches 672 956 +284
=======================================
Hits 5679 5679
Misses 1857 1857
Partials 117 117
Continue to review full report at Codecov.
|
…ejoso/deploy_ethstats
…lo-monorepo into jcortejoso/deploy_ethstats
jcortejoso
commented
Nov 14, 2019
Comment on lines
44
to
55
| function generateAuthorizedAddresses() { | ||
| // TODO: Add the Proxy eth addresses when available | ||
| const mnemonic = fetchEnv(envVar.MNEMONIC) | ||
| const publicKeys = [] | ||
| const txNodes = parseInt(fetchEnv(envVar.TX_NODES), 0) | ||
| const validatorNodes = parseInt(fetchEnv(envVar.VALIDATORS), 0) | ||
| publicKeys.push(getAddressesFor(AccountType.TX_NODE, mnemonic, txNodes)) | ||
| publicKeys.push(getAddressesFor(AccountType.VALIDATOR, mnemonic, validatorNodes)) | ||
|
|
||
| publicKeys.push(fetchEnv(envVar.ETHSTATS_TRUSTED_ENODES).split(',')) | ||
| return publicKeys.reduce((accumulator, value) => accumulator.concat(value), []) | ||
| } |
There was a problem hiding this comment.
@tkporter I adapted to the latest changes Dimi is finishing for using etherbase accounts. Should be ready soon (need to update the commits here). Meanwhile do you think this way is ok for getting the new addresses? It is concatenated the addresses from getAddressesFor with the ones from the env ETHSTATS_TRUSTED_ENODES (this one for external nodes submitting to celostats).
tkporter
reviewed
Nov 14, 2019
…lo-monorepo into jcortejoso/deploy_ethstats
…ejoso/deploy_ethstats
timmoreton
approved these changes
Nov 22, 2019
aaronmgdr
added a commit
that referenced
this pull request
Nov 26, 2019
* master: (61 commits) [Wallet] Handle `/v/<code` deep links for phone verifications (#1776) Patch tslint auto fix for macOS Catalina until tslint#6.x is out (#1802) Fix typos (#1855) Update documentation sidebar (#1861) [Wallet] Update forno dev documentation (#1818) [Docs] Correct typo Validator UX docs for baklava network (#1688) (#1849) Various improvements to the CLI, allow voters to revote for a group (#1840) Serialize to hex string (#1848) Update faucet to pull from the reserve when possible (#1844) Fix elect validators migration, deploy integration (#1847) Configurable genesis balances (#1838) Deploy new version of Celostats and minnor change from celo-blockchain (#1714) Make default node URL consistent in celocli (#1805) Onboarding feedback (#1811) return at least true, when the function is returning bool (#1825) Minor Contractkit changes (#1819) Point end-to-end tests back to master (#1824) Update migration config to correct protocol parameters (#1822) Update with new istanbul lookback window size flag (#1820) ... # Conflicts: # yarn.lock
This was referenced Mar 2, 2022
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the changes to deploy the latest changes over celostats, particularly the ones from celo-org/ethstats-server#6. These changes include multiple UX additions and improvements, some performance tweaks, and particularly important the addition of the lists for authorized and banned nodes to submit to ethstats.
Also
Tested
Tested on a testnet (berlintestnet001), using celotool+helm chart.
Other changes
Included some changes (removing
--miner.verificationpooloption) from celo-org/celo-blockchain#572.I removed the the references in celotool to this option (for helm and terraform) but I can have missed something.
Related issues
Backwards compatibility
Currently we need to complete the
.envvariableETHSTATS_TRUSTED_ENODESwith the enode address of the authorized nodes. I think we plan to change this to use the etherbase account of the authorized nodes, but not sure.The enode address for the nodes deployed in a testnet can be obtained using:
I can move this logic to celotool if we plan to use the enodes for authorizing for longer time.